Remove duplicate type for StaticImageData #27931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
huozhi,
ijjk,
padmaia,
shuding and
timneutkens
as code owners
This comment has been minimized.
This comment has been minimized.
ijjk
approved these changes
Aug 10, 2021
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.936 | 2.957 | |
| / avg req/sec | 851.47 | 845.54 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.832 | 1.845 | |
| /error-in-render avg req/sec | 1364.49 | 1354.83 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| 745.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 23.1 kB | 23.1 kB | ✓ |
| webpack-HASH.js gzip | 1.5 kB | 1.5 kB | ✓ |
| Overall change | 67 kB | 67 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 980 B | 980 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 904 B | 904 B | ✓ |
| image-HASH.js gzip | 4.12 kB | 4.12 kB | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
| script-HASH.js gzip | 387 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 12.8 kB | 12.8 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 490 B | 490 B | ✓ |
| Overall change | 490 B | 490 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| index.html gzip | 531 B | 531 B | ✓ |
| link.html gzip | 544 B | 544 B | ✓ |
| withRouter.html gzip | 523 B | 523 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| buildDuration | 13.2s | 13.4s | |
| buildDurationCached | 5.2s | 5.2s | -37ms |
| nodeModulesSize | 49.1 MB | 49.1 MB | -218 B |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.001 | 2.97 | -0.03 |
| / avg req/sec | 833.08 | 841.63 | +8.55 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.849 | 1.928 | |
| /error-in-render avg req/sec | 1352.33 | 1296.53 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| 17.HASH.js gzip | 185 B | 185 B | ✓ |
| 677f882d2ed8..HASH.js gzip | 14 kB | 14 kB | ✓ |
| framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
| main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 67.9 kB | 67.9 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 965 B | 965 B | ✓ |
| _error-HASH.js gzip | 3.71 kB | 3.71 kB | ✓ |
| amp-HASH.js gzip | 552 B | 552 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| dynamic-HASH.js gzip | 2.71 kB | 2.71 kB | ✓ |
| head-HASH.js gzip | 2.97 kB | 2.97 kB | ✓ |
| hooks-HASH.js gzip | 911 B | 911 B | ✓ |
| index-HASH.js gzip | 231 B | 231 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
| script-HASH.js gzip | 2.95 kB | 2.95 kB | ✓ |
| withRouter-HASH.js gzip | 294 B | 294 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 17.7 kB | 17.7 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 498 B | 498 B | ✓ |
| Overall change | 498 B | 498 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js fix-duplicate-type-StaticImageData | Change | |
|---|---|---|---|
| index.html gzip | 577 B | 577 B | ✓ |
| link.html gzip | 589 B | 589 B | ✓ |
| withRouter.html gzip | 570 B | 570 B | ✓ |
| Overall change | 1.74 kB | 1.74 kB | ✓ |
This was referenced Aug 12, 2021
This was referenced Aug 13, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
Follow up to vercel#27916 This interface was defined twice so I removed the private one and kept the global/public one. https://github.com/vercel/next.js/blob/eb871d30915d668dd9ba897d4d04ced207ce2e6d/packages/next/image-types/global.d.ts#L4-L9 https://github.com/vercel/next.js/blob/b881d65c1289aada030fdbe0b5b70ebf98bcb54c/packages/next/client/image.tsx#L60-L65
This was referenced Sep 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #27916
This interface was defined twice so I removed the private one and kept the global/public one.
next.js/packages/next/image-types/global.d.ts
Lines 4 to 9 in eb871d3
next.js/packages/next/client/image.tsx
Lines 60 to 65 in b881d65